[Piglit] [PATCH v3 21/29] gen_uniform_initializer_tests.py: PEP8 compliance

Chad Versace chad.versace at linux.intel.com
Mon Jul 29 11:19:19 PDT 2013


On 07/24/2013 02:57 PM, Dylan Baker wrote:
> V2: Change some formatting of lines
>
> Signed-off-by: Dylan Baker <baker.dylan.c at gmail.com>
> ---
>   generated_tests/gen_uniform_initializer_tests.py | 65 ++++++++++++------------
>   1 file changed, 33 insertions(+), 32 deletions(-)


> -            test_file_name = dirname = os.path.join('spec',
> -                                                    'glsl-{0}.{1}'.format(major, minor),
> -                                                    'execution',
> -                                                    'uniform-initializer',
> -                                                    '{0}-{1}{2}.shader_test'.format(target, base_name, t))
> +            test_file_name = dirname = os.path.join(
> +                'spec', 'glsl-{0}.{1}'.format(major, minor), 'execution',
> +                'uniform-initializer',
> +                '{0}-{1}{2}.shader_test'.format(target, base_name, t))
>               print test_file_name

The original text had one parameter per line to aid readability. The new text should do that too.


> -        test_file_name = dirname = os.path.join('spec',
> -                                                'glsl-{0}.{1}'.format(major, minor),
> -                                                'execution',
> -                                                'uniform-initializer',
> -                                                '{0}-{1}-array.shader_test'.format(target, base_name))
> +        test_file_name = dirname = os.path.join(
> +            'spec', 'glsl-{0}.{1}'.format(major, minor), 'execution',
> +            'uniform-initializer',
> +            '{0}-{1}-array.shader_test'.format(target, base_name))
>           print test_file_name

Same here, one line per parameter.




More information about the Piglit mailing list