[Piglit] [PATCH v3 22/29] gen_builtin_packing_tests.py PEP8 compliance

Chad Versace chad.versace at linux.intel.com
Mon Jul 29 11:22:29 PDT 2013


On 07/24/2013 02:57 PM, Dylan Baker wrote:
> Remaining PEP8 violations:
> 247, 392: These are part of a mako template that is embedded in the
> 		  python file. A better solution than wrapping them would be to
> 		  split them out of the python and put them in their own mako
> 		  files.
>
> v2: - Fix one of the issues left in v1
>      - Revert to tabluar spacing in tables
>      - Fix indent in two functions per Chad
>      - Revert glsl_es_300 function to be formatted more like it was
>        originally
> v3: - Revert some changes made as a result of false positives from an
>        old version of the pep8 tool
>
> Signed-off-by: Dylan Baker <baker.dylan.c at gmail.com>
> ---
>   generated_tests/gen_builtin_packing_tests.py | 251 +++++++++++++++------------
>   1 file changed, 139 insertions(+), 112 deletions(-)

Reviewed-by: Chad Versace <chad.versace at linux.intel.com>



More information about the Piglit mailing list