[Piglit] [PATCH 1/4] Tests that a pre-declared struct can be used in an interface block.

Matt Turner mattst88 at gmail.com
Tue Jul 30 13:52:03 PDT 2013


On Mon, Jul 29, 2013 at 3:25 PM, Nicholas Mack <nichmack at gmail.com> wrote:
> GLSLang// GLSLangSpec.1.50.11, 4.3.7 Interface Blocks:
> "built-in types, previously declared structures, and arrays of these
> are allowed as the type of a declarator in the same manner they are
> allowed outside a block."
> ---
>  ...rface-blocks-declared-structs-within-block.vert | 28 ++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 tests/spec/glsl-1.50/compiler/interface-blocks-declared-structs-within-block.vert
>
> diff --git a/tests/spec/glsl-1.50/compiler/interface-blocks-declared-structs-within-block.vert b/tests/spec/glsl-1.50/compiler/interface-blocks-declared-structs-within-block.vert
> new file mode 100644
> index 0000000..b77861a
> --- /dev/null
> +++ b/tests/spec/glsl-1.50/compiler/interface-blocks-declared-structs-within-block.vert
> @@ -0,0 +1,28 @@
> +// [config]
> +// expect_result: pass
> +// glsl_version: 1.50
> +// check_link: true
> +// [end config]
> +//
> +// Tests that a pre-declared struct can be used an interface block.
> +//
> +// GLSLangSpec.1.50.11, 4.3.7 Interface Blocks:
> +// "built-in types, previously declared structures, and arrays of these
> +//  are allowed as the type of a declarator in the same manner they are
> +//  allowed outside a block."
> +
> +#version 150
> +
> +struct test_struct {
> +       int a;
> +       float b;
> +};
> +
> +out block {
> +    test_struct c;
> +} inst;
> +
> +void main()
> +{
> +}
> +
> --

Patches 1, 2, and 4 have an extra newline at the end of the file.
Other than that and a comment on #4, all are

Reviewed-by: Matt Turner <mattst88 at gmail.com>


More information about the Piglit mailing list