[Piglit] [PATCH 1/2] glsl-1.50: Test the minimum maximum of gl_MaxCombinedTextureImageUnits

Matt Turner mattst88 at gmail.com
Tue Jul 30 13:59:22 PDT 2013


On Mon, Jul 29, 2013 at 5:08 PM, Nicholas Mack <nichmack at gmail.com> wrote:
> ---
>  .../gl_MaxCombinedTextureImageUnits.shader_test    | 39 ++++++++++++++++++++++
>  1 file changed, 39 insertions(+)
>  create mode 100644 tests/spec/glsl-1.50/execution/maximums/gl_MaxCombinedTextureImageUnits.shader_test
>
> diff --git a/tests/spec/glsl-1.50/execution/maximums/gl_MaxCombinedTextureImageUnits.shader_test b/tests/spec/glsl-1.50/execution/maximums/gl_MaxCombinedTextureImageUnits.shader_test
> new file mode 100644
> index 0000000..94dbbc9
> --- /dev/null
> +++ b/tests/spec/glsl-1.50/execution/maximums/gl_MaxCombinedTextureImageUnits.shader_test
> @@ -0,0 +1,39 @@
> +# [description]
> +# Tests for GLSL 1.50 minimum maximums for the builtin constant
> +# gl_MaxCombinedTextureImageUnits.
> +#
> +# See the GLSL 1.50.09 specification, section 7.4, page 74.

Let's put a comment here (or a spec quote) that says what the minimum
allowed value is. Same comment applies to patch #2.

Otherwise both are: Reviewed-by: Matt Turner <mattst88 at gmail.com>


More information about the Piglit mailing list