[Piglit] [PATCH v2] Expand immutability tests for ARB_texture_storage

Matt Turner mattst88 at gmail.com
Wed Jul 31 12:40:29 PDT 2013


On Wed, Jul 31, 2013 at 12:32 PM, Corey Richardson <corey at octayn.net> wrote:
> On Wed, Jul 31, 2013 at 3:11 PM, Matt Turner <mattst88 at gmail.com> wrote:
>> On Wed, Jul 31, 2013 at 4:47 AM, Corey Richardson <corey at octayn.net> wrote:
>>> +       if (level != 2) {
>>
>> This was level != 4 in the previous patch. Shouldn't you be checking
>> that level != 3 -> error?
>
> The spec actually states that it's clamped to levels - 1, not that
> it's immutable.

Ah, indeed. And you already have a comment explaining that. Looks good to me.


More information about the Piglit mailing list