[Piglit] [v8 12/13] tests/spec: EXT_image_dma_buf_import intel dma-buf with img-ext only

Chad Versace chad.versace at linux.intel.com
Wed Jul 31 16:12:50 PDT 2013


> +static bool
> +try_as_non_external_texture(EGLImageKHR img)
> +{

We may later add testcases for GL_TEXTURE_3D, GL_TEXTURE_CUBE_MAP, etc. So,
let's future-proof this function by naming it 'try_as_texture_2d'.



> +	img = create_image(w, h, fd, stride, offset);
> +	if (!img) {
> +		piglit_destroy_dma_buf(buf);
> +		return PIGLIT_FAIL;
> +	}

Again, as in previous patches, the test should skip not fail if eglCreateImage*
fails with EGL_BAD_MATCH.


More information about the Piglit mailing list