[Piglit] [PATCH 1/6] gs: Make generated geometry shader tests use GLSL 1.50.

Paul Berry stereotype441 at gmail.com
Wed Jul 31 16:57:39 PDT 2013


On 30 July 2013 09:26, Paul Berry <stereotype441 at gmail.com> wrote:

> On 27 July 2013 12:29, Jordan Justen <jljusten at gmail.com> wrote:
>
>> Series Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
>>
>> I was wondering if it would be worth continuing to support the gs4
>> tests? (PATCH 1) Probably not.
>>
>> One other note not directly related to this series. I tried running
>> this series on an nVidia binary driver with GL 3.3 support. I ran:
>> ./piglit-run.py -t glsl-1.50 tests/all.tests results
>>
>> Interestingly, the result was only about 50% of the tests passed. I
>> saw a similar result on master.
>>
>
> Hmm, I don't seem to remember the pass rate being that bad on nVidia.
> I'll do a comparison on my system before pushing this series.
>

Ok, I checked into this and everything looks like an nVidia bug except for
the failures in textureSize and texelFetch.  Those tests are failing
because in patch 6, when I converted those tests over to use GLSL 1.50, I
forgot to remove references to gl_PositionIn (which only exists in
ARB_geometry_shader4).

I'm going to go ahead and push patches 1-5, and I'll rework patch 6 for a
future series.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130731/9b33cf05/attachment-0001.html>


More information about the Piglit mailing list