[Piglit] [PATCH] copyteximage: Enable test vector printfs even when running in -auto mode.

Paul Berry stereotype441 at gmail.com
Mon Jun 3 13:22:30 PDT 2013


Each invocation of the copyteximage test exercises a large number of
test vectors; a failure in a single test vector causes the entire test
to fail.

This patch modifies the printfs that show which test vector is being
tested, so that they execute regardless of whether the test is being
run automatically or manually (previously, they only executed when the
test was run manually).  This makes it much easier to troubleshoot
failures when looking at the output of an automated piglit run.
---
 tests/texturing/copyteximage.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/tests/texturing/copyteximage.c b/tests/texturing/copyteximage.c
index c816768..432ebbc 100644
--- a/tests/texturing/copyteximage.c
+++ b/tests/texturing/copyteximage.c
@@ -441,19 +441,16 @@ test_target_and_format(GLint x, GLint y, GLenum target, GLenum format,
 	GLboolean pass = GL_TRUE;
 	GLuint k;
 
-	if (!piglit_automatic)
-		printf("Texture target = %s, Internal format = %s",
-		       piglit_get_gl_enum_name(target),
-		       piglit_get_gl_enum_name(format));
+	printf("Texture target = %s, Internal format = %s",
+	       piglit_get_gl_enum_name(target),
+	       piglit_get_gl_enum_name(format));
 
 	if (!supported_format(format) ||
 	    !supported_target_format(target, format)) {
-		if (!piglit_automatic)
-			printf(" - skipped\n");
+		printf(" - skipped\n");
 		return GL_TRUE; /* not a failure */
 	} else {
-		if (!piglit_automatic)
-			printf("\n");
+		printf("\n");
 	}
 
 	/* To avoid failures not related to this test case,
-- 
1.8.3



More information about the Piglit mailing list