[Piglit] [PATCH 1/3] Set config.requires_displayed_window in tests that use front buffers.

Chad Versace chad.versace at linux.intel.com
Mon Jun 3 15:52:38 PDT 2013


On 05/31/2013 12:50 PM, Paul Berry wrote:
> When running tests with a non-composited window manager, it isn't safe
> to access the front buffer until after the window is shown.  This
> patch sets config.requires_displayed_window in tests that access front
> buffers, to make sure that the piglit framework exposes the window,
> even when testing in "-auto" mode.
> ---
>   tests/bugs/drawbuffer-modes.c | 1 +
>   tests/fbo/fbo-sys-blit.c      | 1 +
>   tests/fbo/fbo-sys-sub-blit.c  | 1 +
>   tests/general/masked-clear.c  | 1 +
>   4 files changed, 4 insertions(+)






> diff --git a/tests/general/masked-clear.c b/tests/general/masked-clear.c
> index fdf81ba..21fe944 100644
> --- a/tests/general/masked-clear.c
> +++ b/tests/general/masked-clear.c
> @@ -39,6 +39,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>   				PIGLIT_GL_VISUAL_DEPTH |
>   				PIGLIT_GL_VISUAL_STENCIL |
>   				PIGLIT_GL_VISUAL_DOUBLE);
> +	config.requires_displayed_window = true;
>   PIGLIT_GL_TEST_CONFIG_END

Indentation weirdness in masked-clear.c.

Other than that, patch 1 is
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>




More information about the Piglit mailing list