[Piglit] [PATCH] Include enum.spec along with enumext.spec for piglit-dispatch.

Chad Versace chad.versace at linux.intel.com
Wed Jun 5 15:07:17 PDT 2013


On 06/05/2013 02:19 PM, Eric Anholt wrote:
> There are three differences between the two (as verified by sort, sed,
> uniq, and diff):
>
> - enum.spec includes GLES extension enums (since it's used for
>    maintaining uniqueness of enums in the registry), which we want to
>    include for cross-API compatibility.
> - enum.spec includes some entries for known GL versions and GL extensions.
> - enumext.spec has a few more synonyms for enums (since it's the
>    file used for generating the official glext.h for desktop).
>
> This change only introduces new #define lines to generated-dispatch.h.
>
> v2: Make the statement about "only introduces new #define lines"
>      actually true by continuing to emit based on the categories we
>      collected during parsing, except with them defined to '1' instead
>      of '', to match actual glext definitions and what gets
>      autogenerated from enum.ext.
> ---
>
> I swear I had diffed the generated header files when I was writing the
> change.  Maybe I just suck at reading.

I didn't see any errors in the output.
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>


More information about the Piglit mailing list