[Piglit] [PATCH] Add interface blocks that make sure unsized arrays are not allowed.

Kenneth Graunke kenneth at whitecape.org
Sat Jun 8 07:55:27 PDT 2013


On 06/08/2013 03:21 AM, Fabian Bieler wrote:
> On Sat, Jun 8, 2013, at 08:28 AM, Kenneth Graunke wrote:
>> This is explicitly forbidden: "Geometry shader input blocks [...].  All
>> other input and output block arrays must specify an array size."
>>
>> The vertex and fragment shader tests pass on Mesa.  The GS test has not
>> been tested.
>>
>> Cc: Jordan Justen <jljusten at gmail.com>
>> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
>> ---
> [...]
>> a/tests/spec/glsl-1.50/compiler/interface-blocks-unsized-array-out.geom
>> b/tests/spec/glsl-1.50/compiler/interface-blocks-unsized-array-out.geom
>> new file mode 100644
>> index 0000000..f506b72
>> --- /dev/null
>> +++
>> b/tests/spec/glsl-1.50/compiler/interface-blocks-unsized-array-out.geom
>> @@ -0,0 +1,27 @@
>> +// [config]
>> +// expect_result: pass
> I think this test should fail.
> Or the unsized interface block array should be an input block, rather
> than an output block.

Oops...too much cut and paste.  Fixed, thanks!



More information about the Piglit mailing list