[Piglit] [PATCH] glslparsertest: Fix handling of GL_GEOMETRY_VERTICES_OUT_ARB.

Eric Anholt eric at anholt.net
Tue Jun 11 14:28:30 PDT 2013


Paul Berry <stereotype441 at gmail.com> writes:

> When testing geometry shaders, glslparsertest must set
> GL_GEOMETRY_VERTICES_OUT_ARB before linking, since the default value
> of this setting (0) is fairly useless.
>
> Previously, we were accidentally passing the shader name to
> glProgramParameteri() instead of the program name, causing spurious
> errors.
> ---
>  tests/glslparsertest/glslparsertest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/glslparsertest/glslparsertest.c b/tests/glslparsertest/glslparsertest.c
> index 1256b09..bba6cb3 100644
> --- a/tests/glslparsertest/glslparsertest.c
> +++ b/tests/glslparsertest/glslparsertest.c
> @@ -252,7 +252,7 @@ test(void)
>  			 * GL_GEOMETRY_VERTICES_OUT_ARB is zero, which
>  			 * is useless for testing.  Use a value of 3.
>  			 */
> -			glProgramParameteriARB(prog,
> +			glProgramParameteriARB(shader_prog,
>  					       GL_GEOMETRY_VERTICES_OUT_ARB,
>  					       3);

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130611/fff3d2d5/attachment.pgp>


More information about the Piglit mailing list