[Piglit] [PATCH 01/14] glapi: Fix a comment about category names.

[Paul Berry]

On 5 June 2013 16:14, Eric Anholt <eric at anholt.net> wrote:

> Looking at gl.spec and the regexps, that's not what this function did.
> ---
>  glapi/parse_glspec.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/glapi/parse_glspec.py b/glapi/parse_glspec.py
> index 460512a..3f63982 100644
> --- a/glapi/parse_glspec.py
> +++ b/glapi/parse_glspec.py
> @@ -178,9 +178,9 @@ def filter_comments(f):
>  # Convert a category name from the form used in the gl.spec file to
>  # the form we want to output in JSON.  E.g.:
>  #
> -# - "2.1" is converted into { 'kind': 'GL', 'gl_10x_version': 21 }
> +# - "GL_VERSION_2_1" is converted into { 'kind': 'GL', 'gl_10x_version':
> 21 }
>

I think you mean: "VERSION_2_1" is converted into { 'kind': 'GL',
'gl_10x_version': 21 }

With that changed, this patch is:

Reviewed-by: Paul Berry <stereotype441 at gmail.com>


>  #
> -# - "FOO" is converted into { 'kind': 'extension', 'extension_name':
> 'GL_FOO' }
> +# - "ARB_foo" is converted into { 'kind': 'extension', 'extension_name':
> 'GL_ARB_foo' }
>  def translate_category(category_name):
>      m = GL_VERSION_REGEXP.match(category_name)
>      if m:
> --
> 1.8.3.rc0
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130612/965c4979/attachment.html>