[Piglit] [PATCH 01/18] shader_runner: Use piglit_heigth for framebuffer height.

Paul Berry stereotype441 at gmail.com
Thu Jun 13 11:36:29 PDT 2013


On 10 June 2013 15:26, Fabian Bieler <fabianbieler at fastmail.fm> wrote:

> It used to be piglit_width which works, too, as the framebuffer is
> hardcoded
> to 250x250 pixels.
> ---
>  tests/shaders/shader_runner.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

s/heigth/height/ in the subject.


>
> diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
> index 7fc74aa..515fde1 100644
> --- a/tests/shaders/shader_runner.c
> +++ b/tests/shaders/shader_runner.c
> @@ -1751,7 +1751,7 @@ piglit_display(void)
>                                   c + 0, c + 1,
>                                   c + 2, c + 3, c + 4, c + 5) == 6) {
>                         x = c[0] * piglit_width;
> -                       y = c[1] * piglit_width;
> +                       y = c[1] * piglit_height;
>                         if (x >= piglit_width)
>                                 x = piglit_width - 1;
>                         if (y >= piglit_height)
>

It looks like a similar change needs to be made about 20 lines below, in
the handling of "relative probe rgb".

With those changes, this patch is:

Reviewed-by: Paul Berry <stereotype441 at gmail.com>


> --
> 1.8.1.2
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130613/367bc9fc/attachment.html>


More information about the Piglit mailing list