[Piglit] [PATCH 0/4] Don't use piglit_draw_rect* with additional attribute arrays.

Fabian Bieler fabianbieler at fastmail.fm
Wed Jun 19 07:03:03 PDT 2013


The previous commit util: "Draw rectangles using triangle strips instead of quads." introduced some regressions:

The commit swapped the drawing order of the vertices which causes problems for tests that use piglit_draw_rect* with additional attribute arrays.

This series replaces the calls to piglit_draw_rect in such cases with custom glDrawArrays invocations.

Note that patch 2/4 is not strictly necessary since in that case the additional attributes are equal for all vertices.

Sorry for not picking up on this before altering piglit_draw_rect*.
Fabian


Fabian Bieler (4):
  arb_texture_cube_map_array: sample-cube-map-array-shadow use
    glDrawArrays instead of piglit_draw_rect
  glsl-max-varyings: Use glDrawArrays instead of piglit_draw_rect.
  copytemimage: Use glDrawArrays instead of piglit_draw_rect.
  sampler-cube-shadow: Use glDrawArrays instead of piglit_draw_rect.

 tests/shaders/glsl-max-varyings.c                  | 27 +++++--
 .../sampler-cube-array-shadow.c                    | 94 +++++++++++-----------
 tests/texturing/copyteximage.c                     | 45 +++++++----
 tests/texturing/sampler-cube-shadow.c              | 80 +++++++++++-------
 4 files changed, 149 insertions(+), 97 deletions(-)

-- 
1.8.1.2


More information about the Piglit mailing list