[Piglit] [PATCH 1/3] quick.tests: Get glean --quick parameter in piglit-print-commands.

Jose Fonseca jfonseca at vmware.com
Wed Jun 26 05:35:35 PDT 2013


FWIW, another alternative would be to modify piglit-print-commands.py itself. I just noticed it already has a special case for glean tests. I don't mind either way.

Jose

----- Original Message -----
> From: José Fonseca <jfonseca at vmware.com>
> 
> ---
>  framework/gleantest.py | 6 +-----
>  tests/quick.tests      | 6 +++---
>  2 files changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/framework/gleantest.py b/framework/gleantest.py
> index c3b63d8..991861f 100644
> --- a/framework/gleantest.py
> +++ b/framework/gleantest.py
> @@ -40,13 +40,9 @@ class GleanTest(ExecTest):
>                  [gleanExecutable(),
>                  "-o",
>                  "-v", "-v", "-v",
> -                "-t", "+"+name])
> +                "-t", "+"+name] + GleanTest.globalParams)
>          self.name = name
>  
> -    def run(self, valgrind):
> -        self.command += GleanTest.globalParams
> -        return ExecTest.run(self, valgrind)
> -
>      def interpretResult(self, out, returncode, results):
>          if out.find('FAIL') >= 0:
>              results['result'] = 'fail'
> diff --git a/tests/quick.tests b/tests/quick.tests
> index 89ba2c3..58c5d41 100644
> --- a/tests/quick.tests
> +++ b/tests/quick.tests
> @@ -6,8 +6,8 @@
>  import os.path
>  
>  global profile
> -global GleanTest
> -
> -execfile(os.path.dirname(__file__) + '/all.tests')
> +from framework.gleantest import GleanTest
>  
>  GleanTest.globalParams += [ "--quick" ]
> +
> +execfile(os.path.dirname(__file__) + '/all.tests')
> --
> 1.8.1.2
> 


More information about the Piglit mailing list