[Piglit] [PATCH 1/6] Change --tests to --include-tests

Ken Phillis Jr kphillisjr at gmail.com
Mon Mar 4 14:29:05 PST 2013


As I stated in another email, It'll probably be a good idea to allow
the deprecated behavior for a few more months, and instead print a
warning message when users attempt to use deprecated options.

On Sat, Mar 2, 2013 at 6:00 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> Excluding tests already uses a similar syntax (--exclude-tests), so this
> is more consistent.
>
> Signed-off-by: Dylan Baker <baker.dylan.c at gmail.com>
> ---
>  piglit-print-commands.py | 6 +++---
>  piglit-run.py            | 6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/piglit-print-commands.py b/piglit-print-commands.py
> index 7a3ba14..c01248b 100755
> --- a/piglit-print-commands.py
> +++ b/piglit-print-commands.py
> @@ -48,7 +48,7 @@ Prints a list of all the tests and how to run them.  Ex:
>
>  Options:
>    -h, --help                Show this message
> -  -t regexp, --tests=regexp Run only matching tests (can be used more
> +  -t regexp, --include-tests=regexp Run only matching tests (can be used more
>                              than once)
>    -x regexp, --exclude-tests=regexp Exclude matching tests (can be used
>                              more than once)
> @@ -70,7 +70,7 @@ def main():
>         try:
>                 option_list = [
>                          "help",
> -                        "tests=",
> +                        "include-tests=",
>                          "exclude-tests=",
>                          ]
>                 options, args = getopt(sys.argv[1:], "ht:x:", option_list)
> @@ -85,7 +85,7 @@ def main():
>         for name, value in options:
>                 if name in ('-h', '--help'):
>                         usage()
> -               elif name in ('-t', '--tests'):
> +               elif name in ('-t', '--include-tests'):
>                         test_filter.append(value)
>                         env.filter.append(re.compile(value))
>                 elif name in ('-x', '--exclude-tests'):
> diff --git a/piglit-run.py b/piglit-run.py
> index 8da99a0..0ab8fc6 100755
> --- a/piglit-run.py
> +++ b/piglit-run.py
> @@ -45,7 +45,7 @@ Usage: %(progName)s [options] [profile.tests] [results]
>  Options:
>    -h, --help                Show this message
>    -d, --dry-run             Do not execute the tests
> -  -t regexp, --tests=regexp Run only matching tests (can be used more
> +  -t regexp, --include-tests=regexp Run only matching tests (can be used more
>                              than once)
>    -x regexp, --exclude-tests=regexp Excludey matching tests (can be used
>                              more than once)
> @@ -81,7 +81,7 @@ def main():
>                          "dry-run",
>                          "resume",
>                          "valgrind",
> -                        "tests=",
> +                        "include-tests=",
>                          "name=",
>                          "exclude-tests=",
>                          "concurrent=",
> @@ -106,7 +106,7 @@ def main():
>                         OptionResume = True
>                 elif name in ('--valgrind'):
>                         env.valgrind = True
> -               elif name in ('-t', '--tests'):
> +               elif name in ('-t', '--include-tests'):
>                         test_filter.append(value)
>                         env.filter.append(re.compile(value))
>                 elif name in ('-x', '--exclude-tests'):
> --
> 1.8.1.2
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit


More information about the Piglit mailing list