[Piglit] [PATCH 2/2] depthstencil-render-miplevels: Add test for size 273.

Paul Berry stereotype441 at gmail.com
Mon Mar 11 10:54:00 PDT 2013


When a mipmapped depth texture's size satisfies size > 1 and (size %
16) == 1, this causes miplevel 1 to have a size that is a multiple of
8, but not to be aligned on a multiple of 8 boundary.  This turns out
to be an important corner case for the i965 driver.

Note: in an ideal world, I'd modify depthstencil-render-miplevels to
simply test every possible buffer size from 1 to some reasonably large
size (perhaps 256), but this would produce an impractically large
number of test cases.  So instead I'm just testing the sizes that have
been known to cause problems.
---
 tests/all.tests | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/tests/all.tests b/tests/all.tests
index 20120d1..5a29da7 100644
--- a/tests/all.tests
+++ b/tests/all.tests
@@ -87,10 +87,9 @@ def add_fbo_depthstencil_tests(group, format):
 
 
 def add_depthstencil_render_miplevels_tests(group, test_types):
-        # Note: the buffer sizes of 146, 292, 585, and 1024 have been
-        # chosen to exercise all possible combinations of buffer
-        # alignments on i965.
-        for texture_size in (146, 292, 585, 1024):
+        # Note: the buffer sizes below have been chosen to exercise
+        # many possible combinations of buffer alignments on i965.
+        for texture_size in (146, 273, 292, 585, 1024):
                 for test_type in test_types:
                         test_name = 'depthstencil-render-miplevels {0} {1}'.format(
                                 texture_size, test_type)
-- 
1.8.1.5



More information about the Piglit mailing list