[Piglit] [PATCH] shader_runner: remove explicit #version from outerProduct generated tests.

Stuart Abercrombie sabercrombie at google.com
Tue Mar 12 11:17:41 PDT 2013


You're absolutely right.  I guess shader_runner just ignored that, because
it did work.  I'll send a new version.


On Mon, Mar 11, 2013 at 11:02 PM, Jordan Justen <jljusten at gmail.com> wrote:

> 2013/3/11 Stuart Abercrombie <sabercrombie at chromium.org>:
> > diff --git a/tests/spec/glsl-1.20/execution/outerProduct.sh
> b/tests/spec/glsl-1.20/execution/outerProduct.sh
> > index ecea80d..ff33449 100755
> > --- a/tests/spec/glsl-1.20/execution/outerProduct.sh
> > +++ b/tests/spec/glsl-1.20/execution/outerProduct.sh
> > @@ -86,6 +86,9 @@ GL >= 2.1
> >      fi
> >
> >      cat > $name <<EOF
> > +# Test generated by:
> > +$0
>
> Other similar situations seem to use:
> echo "# Test generated by:"
> echo "# ${cmd}"
>
> tests/spec/glsl-1.10/variable-index-read.sh
> tests/spec/glsl-1.10/variable-index-read.sh
> tests/spec/glsl-1.10/variable-index-write.sh
> tests/spec/glsl-1.10/variable-index-write.sh
>
> Should the second line be commented?
>
> -Jordan
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130312/0fcb4854/attachment.html>


More information about the Piglit mailing list