[Piglit] [PATCH v2] Test some interactions with multiple inout parameters

Eric Anholt eric at anholt.net
Wed Mar 27 18:05:04 PDT 2013

Ian Romanick <idr at freedesktop.org> writes:

> From: Ian Romanick <ian.d.romanick at intel.com>
> There are several variations of
> void foo(inout int i, inout float f);
> ...
> foo(i, f[i]);
> that Mesa's GLSL compiler gets wrong.  NVIDIA's closed-source driver
> (version 304.64) fails vs-inout-index-inout-mat2-col.shader_test and
> vs-inout-index-inout-mat2-row.shader_test, but passes the others.
> v2: Use 'proble all rgb' and make vs-inout-index-inout-mat2-col use u=1
> like the other tests.  Both items were suggested by Eric Anholt.  I use
> 'probe all rgb' because the tests actually write 0 for alpha, but
> shader_runner doesn't always get an RGBA visual (so alpha will be 0 or
> 1).  Also, add two simpler tests vs-out-vec4 and vs-inout-vec4.  This
> currently pass, but a patch series I have in progress had broken them.

Other than the note that shader_runner does actually always get an RGBA

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130327/76a9f5c8/attachment.pgp>

More information about the Piglit mailing list