[Piglit] [v4 4/4] tests: spec: tests for EXT_image_dma_buf_import

Pohjolainen, Topi topi.pohjolainen at intel.com
Fri May 3 02:12:47 PDT 2013

On Fri, May 03, 2013 at 10:54:12AM +0200, Daniel Vetter wrote:
> On Thu, May 02, 2013 at 04:57:49PM -0700, Eric Anholt wrote:
> > > +#define fourcc_code(a,b,c,d) ((uint32_t)(a) | ((uint32_t)(b) << 8) | \
> > > +				((uint32_t)(c) << 16) | ((uint32_t)(d) << 24))
> > > +#define DRM_FORMAT_ARGB8888 fourcc_code('A', 'R', '2', '4')
> > 
> > This is in many subtests, and should pretty clearly be in a header.
> That thing is in the drm_fourcc.h kernel userspace header. Do we just need
> a check to make sure the linux-headers are recent enough?

I tried to keep the tests platform independent, and this was to avoid any need
for libdrm inclusions there. (One checks for particular driver and platform
in the framework and uses their settings for inclusions and libraries).

I could add a common header if you like. But then again there are a quite a bit
of other things in all the tests that one could start refactoring, and these
one-liners weren't on top of my list.

More information about the Piglit mailing list