[Piglit] [PATCH] max-samplers: use the maximum number of textures in every shader

Brian Paul brianp at vmware.com
Thu May 9 07:21:23 PDT 2013

On 05/08/2013 07:27 PM, Marek Olšák wrote:
> On Thu, May 9, 2013 at 1:16 AM, Brian Paul<brianp at vmware.com>  wrote:

>> BTW, I tried to test this with NVIDIA's driver but it appears that piglit
>> can't create a GL 3.1 context:
>> $ bin/gl-3.1-max-samplers -auto
>> piglit: info: Failed to create GL 3.1 core context
>> piglit: info: Failed to create any GL context
>> PIGLIT: {'result': 'skip' }
> The issue with NVIDIA's driver is that it advertises
> ARB_compatibility, so it's not a 3.1 core profile. Piglit sees that
> and assumes the context creation failed and skips the test.

It also doesn't run if I try to request a GL 3.1 compatibility context.

Does this test really need GL 3.1?  I changed the test to use 
config.supports_gl_compat_version = 20 (AFAICT only GL 2.0 features 
are used).  Plus, I had to increase the window size to 300x300 because 
32 vertex/fragment image units are reported on my system.  Now the 
test passes with my NVIDIA driver.

A patch with my changes is attached.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: max-samplers.patch
Type: application/pgp-keys
Size: 1167 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130509/134078ed/attachment.key>

More information about the Piglit mailing list