[Piglit] [PATCH v2 04/11] piglit-summary-py: Use the new summary class to generate HTML
baker.dylan.c at gmail.com
Fri May 17 13:27:33 PDT 2013
You're probably right. I'll make that change too.
Though I am wondering if it's even worth having the list syntax, it's been
broken for over two months and no one has complained or even noticed it
until now. If it's still useful to someone I'll fix it, but if no one's
using it it is a fairly clunky mechanism. I'd prefer to see just a space,
comma, or newline separated list of files in a file rather than the python
list of lists that behaves rather strangely.
On Fri, May 17, 2013 at 1:21 PM, Ken Phillis Jr <kphillisjr at gmail.com>wrote:
> I am wondering...
> Where is the help information over the lists file? The best placement
> to show an Example list file is to use the epilog argument to the
> ArgumentParser, and set the formatter_class to
> "argparse.RawDescriptionHelpFormatter" Documentation on this is as
> Argument Parser Epilog information:
> ArgumentParser formatter_class information:
> On Fri, May 17, 2013 at 11:31 AM, Dylan Baker <baker.dylan.c at gmail.com>
> > Drops almost all of the code used in this file, all of that
> > functionality is now handled in the summary class. Instead, the majority
> > of this file is just the argparse instance, and a few short lines
> > calling the new summary class.
> > V2: Fixes the -l/--list syntax
> > Signed-off-by: Dylan Baker <baker.dylan.c at gmail.com>
> > ---
> > piglit-summary-html.py | 284
> > 1 file changed, 32 insertions(+), 252 deletions(-)
> > diff --git a/piglit-summary-html.py b/piglit-summary-html.py
> > index 86555e3..77d63d0 100755
> > --- a/piglit-summary-html.py
> > +++ b/piglit-summary-html.py
> [ Trimmed ]
> > def main():
> > parser = argparse.ArgumentParser()
> [ Trimmed ]
> The argparse.ArgumentParser here needs a small update. This is where
> an the epilog and formatter_class function parameters need to be
> defined in order to let users know how to format the list file.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Piglit