[Piglit] [PATCH 4/7] gl-3.2: Add testing for the minimum maximums.

[Eric Anholt]

Brian Paul <brian.e.paul at gmail.com> writes:

> On May 16, 2013, at 9:28 AM, Eric Anholt <eric at anholt.net> wrote:
>> diff --git a/tests/spec/CMakeLists.txt b/tests/spec/CMakeLists.txt
>> +/** @file minmax.c
>> + *
>> + * Test for the minimum maximum values in section 6.2 "State Tables"
>> + * of the GL 3.2 spec.
>> + */
>> +
>> +#include "piglit-util-gl-common.h"
>> +#include "minmax-test.h"
>> +
>> +PIGLIT_GL_TEST_CONFIG_BEGIN
>> +
>> +    config.supports_gl_core_version = 32;
>> +    config.supports_gl_compat_version = 10;
>> +
>> +    config.window_width = 32;
>> +    config.window_height = 32;
>
> I think you can omit the window size. 

Done.

>> +void
>> +piglit_init(int argc, char **argv)
>> +{
>> +    int vuniforms = 0, vblocks = 0;
>> +    int guniforms = 0, gblocks = 0;
>> +    int funiforms = 0, fblocks = 0;
>> +    int blocksize = 0;
>> +
>> +    piglit_require_gl_version(31);
>
> Is that needed if you specified version info in the config block
> above? I guess I'm not clear on this in general.

Nope:

piglit: info: Failed to create GL 3.2 core context
piglit: info: Falling back to GL 3.2 compatibility context
piglit: info: Requested a GL 3.2 compatibility context, but actual context version is 3.0
piglit: info: Failed to create GL 3.2 compatibility context
piglit: info: Failed to create any GL context
PIGLIT: {'result': 'skip' }

I've removed those lines.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130521/3f8db686/attachment.pgp>