[Piglit] [PATCH] util: Don't call exit() after piglit_report_result()

Chad Versace chad.versace at linux.intel.com
Thu May 30 15:46:06 PDT 2013

On 05/29/2013 02:46 PM, Ian Romanick wrote:
> On 05/15/2013 11:29 AM, Chad Versace wrote:
>> Any call to exit() that follows piglit_report_result() is nothing more
>> than confusing dead code.  piglit_report_result() already calls exit(),
>> and chooses the exit code according to the PIGLIT_$RESULT value.
> A couple of minor things that I noticed while reviewing this patch:
>   * There's a redundant exit() call after piglit_report_result in tests/cl/program/program-tester.c,
> tests/egl/spec/egl_khr_create_context/verify-gl-flavor.c, tests/fbo/fbo-draw-buffers-blend.c, and
> tests/glslparsertest/glslparsertest.c.
>   * There's also a redundant exit() call not after piglit_report_result in
> tests/spec/ext_texture_integer/getteximage-clamping.c.
>   * The exit() calls in tests/spec/ext_transform_feedback/get-buffer-state.c,
> tests/spec/ext_transform_feedback/builtin-varyings.c, and tests/spec/ext_transform_feedback/api-errors.c return the
> wrong value.
>   * The exit() usage in tests/spec/amd_performance_monitor/measure.c and tests/spec/amd_performance_monitor/api.c are
> weird.
>   * tests/texturing/crossbar.c should use piglit_report_result and remove the call to exit.
> If you fix the first one, I'll send out patches that fix the others. With that,
> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

First item fixed, and now pushed.

More information about the Piglit mailing list