[Piglit] [PATCH 1/3] Set config.requires_displayed_window in tests that use front buffers.

Paul Berry stereotype441 at gmail.com
Fri May 31 12:50:08 PDT 2013


When running tests with a non-composited window manager, it isn't safe
to access the front buffer until after the window is shown.  This
patch sets config.requires_displayed_window in tests that access front
buffers, to make sure that the piglit framework exposes the window,
even when testing in "-auto" mode.
---
 tests/bugs/drawbuffer-modes.c | 1 +
 tests/fbo/fbo-sys-blit.c      | 1 +
 tests/fbo/fbo-sys-sub-blit.c  | 1 +
 tests/general/masked-clear.c  | 1 +
 4 files changed, 4 insertions(+)

diff --git a/tests/bugs/drawbuffer-modes.c b/tests/bugs/drawbuffer-modes.c
index b155c1e..eb50080 100644
--- a/tests/bugs/drawbuffer-modes.c
+++ b/tests/bugs/drawbuffer-modes.c
@@ -41,6 +41,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
 	config.supports_gl_compat_version = 10;
 
 	config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
+	config.requires_displayed_window = true;
 
 PIGLIT_GL_TEST_CONFIG_END
 
diff --git a/tests/fbo/fbo-sys-blit.c b/tests/fbo/fbo-sys-blit.c
index c4bd588..4561be3 100644
--- a/tests/fbo/fbo-sys-blit.c
+++ b/tests/fbo/fbo-sys-blit.c
@@ -36,6 +36,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
 	config.window_width = 128;
 	config.window_height = 128;
 	config.window_visual = PIGLIT_GL_VISUAL_DOUBLE | PIGLIT_GL_VISUAL_RGB;
+	config.requires_displayed_window = true;
 
 PIGLIT_GL_TEST_CONFIG_END
 
diff --git a/tests/fbo/fbo-sys-sub-blit.c b/tests/fbo/fbo-sys-sub-blit.c
index 30dcb0f..a6e331e 100644
--- a/tests/fbo/fbo-sys-sub-blit.c
+++ b/tests/fbo/fbo-sys-sub-blit.c
@@ -37,6 +37,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
 	config.window_width = 128;
 	config.window_height = 128;
 	config.window_visual = PIGLIT_GL_VISUAL_DOUBLE | PIGLIT_GL_VISUAL_RGB;
+	config.requires_displayed_window = true;
 
 PIGLIT_GL_TEST_CONFIG_END
 
diff --git a/tests/general/masked-clear.c b/tests/general/masked-clear.c
index fdf81ba..21fe944 100644
--- a/tests/general/masked-clear.c
+++ b/tests/general/masked-clear.c
@@ -39,6 +39,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
 				PIGLIT_GL_VISUAL_DEPTH |
 				PIGLIT_GL_VISUAL_STENCIL |
 				PIGLIT_GL_VISUAL_DOUBLE);
+	config.requires_displayed_window = true;
 PIGLIT_GL_TEST_CONFIG_END
 
 
-- 
1.8.3



More information about the Piglit mailing list