[Piglit] [PATCH] update the HACKING file's Coding style section

[Ken Phillis Jr]

We Probably should also have two reminders for people that will be highly
useful.

1) To please pay attention to the various FileSystem valid file names. This
means to refer to the relevant wikipedia article (
http://en.wikipedia.org/wiki/Filename ) over this and pay attention to what
each platform can handle. As a good rule of Thumb for File name Limitations
I would use "Windows VFAT", NTFS, Mac OS HFS+ and Posix as a list. This
means that the following characters should not be generated filenames (
This is key for Python since glean is known to generate one or more of
these).... :|\?*<":>+[]/

2) Overall file names need to be somewhat Limited. I understand that 70
characters in a single filename is fine, but a reminder that overall
filesystem limitations still matter. Two tests exist that already exist
that violate this principle and those are...
same-attachment-glFramebufferRenderbuffer-GL_DEPTH_STENCIL_ATTACHMENT and
same-attachment-glFramebufferTexture2D-GL_DEPTH_STENCIL_ATTACHMENT. With
these tests, the cmake overhead winds up turning them into a mess that can
easily exceed 256 characters in a path. because the longest file for each
of these are as follows...

target_api/gl/tests/spec/arb_framebuffer_object/CMakeFiles/same-attachment-glFramebufferRenderbuffer-GL_DEPTH_STENCIL_ATTACHMENT.dir/same-attachment-glFramebufferRenderbuffer-GL_DEPTH_STENCIL_ATTACHMENT.c.o
and
target_api/gl/tests/spec/arb_framebuffer_object/CMakeFiles/same-attachment-glFramebufferTexture2D-GL_DEPTH_STENCIL_ATTACHMENT.dir/same-attachment-glFramebufferTexture2D-GL_DEPTH_STENCIL_ATTACHMENT.c.o


With both of these, it is easy to see that the file name is really long and
can easily get out of hand. On windows this is especially bad when you take
into considering that a user will probably try to build the source from
their desktop and that can easily add another 34 characters... Just as a
note, nmake ( and visual studio ) can run into a problem if the full path
exceeds 218 characters ( See: http://support.microsoft.com/kb/213983 NOTE:
This applies to excel, but does occur when using visual studio 2010 also )


On Mon, Nov 4, 2013 at 8:41 AM, Brian Paul <brianp at vmware.com> wrote:

> On 11/02/2013 09:02 PM, Dylan Baker wrote:
>
>> Could you add a note about python code?
>>
>> Just something like: "All python code should conform to python's PEP8
>> standard, using only spaces and no tabs" would be great.
>>
>
> Go for it!
>
> -Brian
>
>
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20131104/5c31eebc/attachment.html>