[Piglit] [PATCH 0/7] Reducing ortho use in shader_runner

Matt Turner mattst88 at gmail.com
Tue Nov 5 09:54:00 PST 2013


On Tue, Nov 5, 2013 at 9:38 AM, Ian Romanick <idr at freedesktop.org> wrote:
> On 11/04/2013 10:18 PM, Matt Turner wrote:
>> We'd like to shrink the window sizes of shader runner when running in
>> simulation, and ortho tests make it difficult to reason about reducing
>> the window size.
>>
>> The following patches fix some tests and test generators to use
>> non-ortho projections instead. This should allow us to shrink these
>> tests' window sizes and execute them faster. They reduce the number of
>> occurrences of 'ortho' in shader_test files in piglit from 920 to 153.
>>
>> I have some additional patches that delete these generated tests from
>> git and move their generators to generated_tests/, but since the
>> generators are written in bash (I assume?) they're really slow. I'm
>> not sure if it's worth it, but we would remove 60k lines of generated
>> code from piglit.
>
> The bigger problem is that piglit builds on platforms that may not have
> bash.  Right?  We'd have to convert them to Python... and that feels
> like too much work.  Too bad we don't still have a bunch of interns
> around. :)

I suppose. I'm personally not so concerned about that, given the
number of plausible results I see googling for "bash for windows"

Converting to python might make them not run so slowly though.


More information about the Piglit mailing list