[Piglit] [PATCH 3/7] shaders: Stop using ortho in glsl-const tests.

Kenneth Graunke kenneth at whitecape.org
Tue Nov 5 10:39:05 PST 2013

On 11/05/2013 09:52 AM, Matt Turner wrote:
> On Tue, Nov 5, 2013 at 9:36 AM, Ian Romanick <idr at freedesktop.org> wrote:
>> On 11/04/2013 10:27 PM, Matt Turner wrote:
>>> Scripted with sed with fix ups to
>>>  - not - actually writes .w component, so probe rgba.
>>>  - reflect - writes const 1.0 .w component, so probe rgb.
>>>  - cosh - writes const 1.0 .w component, and used probe rgb with 4
>>>    components, so drop the .w from the probe.
>> I'm unsure about removing the 'clear'.  It seems like we put that in for
>> a reason, but it was about 100 years ago.
> The tests draw small green squares onto a cleared background, so I
> think the clear is just because we're not drawing over the whole
> surface and want some defined values. But now that we're drawing the
> whole window, we shouldn't need it, like most other piglit tests.

Yep, the clear was just to make it look sensible when you visually
inspected the results.  Now that you're drawing over the whole window,
there's no need for it.

Patches 1-3 are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

More information about the Piglit mailing list