[Piglit] [PATCH 2/7] shaders: Remove #version from glsl-const tests.

Kenneth Graunke kenneth at whitecape.org
Tue Nov 5 11:01:16 PST 2013


On 11/05/2013 10:49 AM, Matt Turner wrote:
> On Tue, Nov 5, 2013 at 10:43 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:
>> On 11/04/2013 10:27 PM, Matt Turner wrote:
>>> Also basically a revert of 6533d757 to make the cosh test match.
>>
>> Wait, I rescind my review of this patch...sorry.
>>
>> outerProduct, transpose, determinant, and inverse are only available
>> with #version 120 and later.
>>
>> You'll need to leave it for outerProduct and transpose.  With those
>> hunks dropped, for real this time,
>>
>> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
> 
> shader_runner puts in a #version 120 since we have GLSL >= 1.20.
> 
> This change is a no-op.

Gaaaaaah.  I always forget that it does that now.  So confusing.

Fine by me then, assuming you tested it and it works.



More information about the Piglit mailing list