[Piglit] [PATCH] gs: Fix geometry layout case insensitivity tests.

Ian Romanick idr at freedesktop.org
Wed Nov 6 14:07:47 PST 2013


On 10/15/2013 05:33 PM, Paul Berry wrote:
> These tests use check_link: true, which means that they each need to
> specify a complete set of geometry shader layout qualifiers in order
> to pass.

If we had it to do over again, we might have been better off doing all
of them in one test case. *shrug*

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

> ---
>  tests/spec/glsl-1.50/compiler/layout-not-case-sensitive-in.geom       | 1 +
>  tests/spec/glsl-1.50/compiler/layout-not-case-sensitive-max-vert.geom | 2 ++
>  tests/spec/glsl-1.50/compiler/layout-not-case-sensitive-out.geom      | 2 ++
>  3 files changed, 5 insertions(+)
> 
> diff --git a/tests/spec/glsl-1.50/compiler/layout-not-case-sensitive-in.geom b/tests/spec/glsl-1.50/compiler/layout-not-case-sensitive-in.geom
> index d5d8ec5..23a5d26 100644
> --- a/tests/spec/glsl-1.50/compiler/layout-not-case-sensitive-in.geom
> +++ b/tests/spec/glsl-1.50/compiler/layout-not-case-sensitive-in.geom
> @@ -11,6 +11,7 @@
>  #version 150
>  
>  layout(TriAngleS) in;
> +layout(triangle_strip, max_vertices = 3) out;
>  
>  void main()
>  {
> diff --git a/tests/spec/glsl-1.50/compiler/layout-not-case-sensitive-max-vert.geom b/tests/spec/glsl-1.50/compiler/layout-not-case-sensitive-max-vert.geom
> index 4838b33..9632127 100644
> --- a/tests/spec/glsl-1.50/compiler/layout-not-case-sensitive-max-vert.geom
> +++ b/tests/spec/glsl-1.50/compiler/layout-not-case-sensitive-max-vert.geom
> @@ -11,6 +11,8 @@
>  #version 150
>  
>  layout(maX_VERTices = 50) out;
> +layout(triangles) in;
> +layout(triangle_strip) out;
>  
>  void main()
>  {
> diff --git a/tests/spec/glsl-1.50/compiler/layout-not-case-sensitive-out.geom b/tests/spec/glsl-1.50/compiler/layout-not-case-sensitive-out.geom
> index eaadf8a..de8f25f 100644
> --- a/tests/spec/glsl-1.50/compiler/layout-not-case-sensitive-out.geom
> +++ b/tests/spec/glsl-1.50/compiler/layout-not-case-sensitive-out.geom
> @@ -11,6 +11,8 @@
>  #version 150
>  
>  layout(pOiNtS) out;
> +layout(triangles) in;
> +layout(max_vertices = 3) out;
>  
>  void main()
>  {
> 



More information about the Piglit mailing list