[Piglit] [PATCH] Add a "Contributing Patches" section to the HACKING file.
Paul Berry
stereotype441 at gmail.com
Wed Nov 13 11:26:51 PST 2013
On 13 November 2013 11:01, Frank Henigman <fjhenigman at google.com> wrote:
> I'd like to see an explanation of "signed-off-by," "reviewed-by" etc.
> Maybe as simple as:
>
> "Use the tags signed-off-by, reviewed-by, tested-by, acked-by as for linux
> kernel patches
> (see https://www.kernel.org/doc/Documentation/SubmittingPatches)."
>
That seems reasonable. Note, however, that Piglit doesn't consistently use
"signed-off-by":
$ git log master | grep '^commit' | wc
4885 9770 234480
$ git log master | grep -i 'signed-off-by' | wc
1241 4969 70925
(If you'd like to encourage us to start using "signed-off-by" consistently,
I'm happy to have a policy discussion about that, but the discussion should
happen in its own email thread rather than here, so that more people will
see it).
I'll follow up with a patch taking your suggestion into account.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20131113/e5189529/attachment.html>
More information about the Piglit
mailing list