[Piglit] [PATCH 1/2] framework/summary.py: Set constants for directories

Dylan Baker baker.dylan.c at gmail.com
Thu Nov 14 07:57:54 PST 2013


On Wednesday, November 13, 2013 09:58:32 PM Damien Lespiau wrote:
> On Wed, Nov 13, 2013 at 12:51:27PM -0800, Dylan Baker wrote:
> > PIGLIT_SOURCE_DIR is always set in core.py in an way nearly identical to
> > the way you're looking for piglitDir, which we import, so I don't think
> > this should be an issue
> 
> Oh, in that case, looks good to me. You probably want a r-b tag from
> someone knowing piglit better though, I've just looked at it for the
> first time today for our usage in intel-gpu-tools.
> 
> In any case, that's what I want and done as well, making the html
> summary script run with an installed piglit.
> 
> Reviewed-by: Damien Lespiau <damien.lespiau at intel.com>

getting an r-b for any python related code I wrote is a nice change, I'll take 
whatever I can get :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20131114/252311f3/attachment.pgp>


More information about the Piglit mailing list