[Piglit] [PATCH v3 1/2] summary.py: Treat subtests as groups

Dylan Baker baker.dylan.c at gmail.com
Fri Nov 15 11:15:14 PST 2013


On Friday, November 15, 2013 06:25:48 PM Damien Lespiau wrote:
> On Thu, Nov 14, 2013 at 10:26:08AM -0800, Dylan Baker wrote:
> > This patch causes tests with subtests to be treated as a group, rather
> > than as a test. This means that the status the test itself stores will
> > be overwritten by those in the subtest.
> > 
> > There is one oddity about this to be aware of; a test with subtests that
> > crashes or fails before any of the subtests run will report a fraction
> > of 0/1 with the appropriate color, even though all of the subtests will
> > report Not Run.
> > 
> > v2: - Add subtests to the results file as full tests (the internal view
> > 
> >       of the json), without this they will not appear in changes, fixes,
> >       etc
> >     
> >     - Render the background color of Not Run tests correctly in HTML
> >     - Apply subtest fractions down the stack
> > 
> > v3: - Don't generate a link for Not Run tests in html page
> > 
> > Tested-by: Tom Stellard <thomas.stellard at amd.com>
> > Signed-off-by: Dylan Baker <baker.dylan.c at gmail.com>
> 
> This patch regresses the HTML output here. For tests that do run-time
> checks and return 77 (skip), they are now marked as "Not Run" instead of
> "skip". This also matters because skip had a link to the details and the
> output of skipped tests is usally of interest (it has the reason of the
> skip)
> 
> Mind fixing this?

Since there are now two non-trivial major bugs on this feature I've reverted 
it and I'll send out patches to the list again when I have it working.

sorry guys.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20131115/af2b3031/attachment.pgp>


More information about the Piglit mailing list