[Piglit] [PATCH] framework: Fix resuming of previous runs

Ken Phillis Jr kphillisjr at gmail.com
Fri Nov 15 18:01:14 PST 2013


I also find that being able to resume tests is also very important. There
is never a complete guarantee that a computers driver will be able to run
all tests from start to finish. It's really important to be able to test
all of the driver from start to finish, but in cases when it suddenly stops
it would be good to know this.


Also, It may be useful to have include the following when piglit is resumed.
1) resuming of previous time counter. ( Resume always causes a reset of the
elapsed time. )
2) How many times the test is resumed. As Damien said there is often times
a case where there is repeated system hangs.
3) whether or not the resume went from threaded or not. Although it would
be good if the test just resumed using the previously stored settings.



On Fri, Nov 15, 2013 at 11:09 AM, Damien Lespiau
<damien.lespiau at intel.com>wrote:

> On Fri, Nov 15, 2013 at 08:51:42AM -0800, Dylan Baker wrote:
> > > This looks fine. I had implemented this when I did the status work,
> but then
> > > didn't think I needed it. Resume is not a commonly used feature
> obviously.
>
> FWIW, it's something we really need working with the i915 test-suite in
> intel-gpu-tools. Some tests there are not very gentle and are likely to
> cause hard hangs.
>
> Thanks for the review.
>
> --
> Damien
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20131115/384bf14e/attachment.html>


More information about the Piglit mailing list