[Piglit] [PATCH 2/2] core: don't report warn if stderr is not empty

Daniel Vetter daniel at ffwll.ch
Wed Nov 20 01:51:11 PST 2013


On Tue, Nov 19, 2013 at 10:52:38AM -0800, Eric Anholt wrote:
> Marek Olšák <maraeo at gmail.com> writes:
> 
> > From: Marek Olšák <marek.olsak at amd.com>
> >
> > The usefulness of this is questionable to say the least.
> 
> My initial reaction was to be against this one, but I think I'm OK with
> it, actually.  While it's caught issues for me a few times with leaving
> in debug printfs, my debug printfs are usually to stdout anyway.

Yeah, the warn state was occasionally useful for igt tests when I've
botched something in the igt result helper code or left a debug printf in
a test. Otherwise it only resulted in a bit of churn to rid ourselves of
all the status outputs to stderr. So didn't really add any value here
either.

Acked-by: Daniel Vetter <daniel.vetter at ffwll.ch>
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the Piglit mailing list