[Piglit] [PATCH] piglit: don't report fail for WAFFLE_ERROR_BUILT_WITHOUT_SUPPORT

Jose Fonseca jfonseca at vmware.com
Wed Nov 20 09:23:30 PST 2013


Sounds good to me

Jose

----- Original Message -----
> On 11/18/2013 01:59 PM, Brian Paul wrote:
> > If we build waffle w/out ES support and we run all.tests, quick.tests,
> > etc. we get lots of 'fail' results for the ES tests.  This change causes
> > those tests to be reported as 'skip' instead.
> > ---
> >   tests/util/piglit-util-waffle.c |    3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/util/piglit-util-waffle.c
> > b/tests/util/piglit-util-waffle.c
> > index ade3987..b1ad0a2 100644
> > --- a/tests/util/piglit-util-waffle.c
> > +++ b/tests/util/piglit-util-waffle.c
> > @@ -82,7 +82,8 @@ wfl_fatal_error(const char *func_name)
> >
> >   	wfl_log_error(func_name);
> >
> > -	if (info->code == WAFFLE_ERROR_UNSUPPORTED_ON_PLATFORM)
> > +	if (info->code == WAFFLE_ERROR_UNSUPPORTED_ON_PLATFORM ||
> > +	    info->code == WAFFLE_ERROR_BUILT_WITHOUT_SUPPORT)
> >   		piglit_report_result(PIGLIT_SKIP);
> >   	else
> >   		piglit_report_result(PIGLIT_FAIL);
> >
> 
> Ping?
> 
> -Brian
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/piglit&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr9uy2iTjWVixC0wOcYCWEIYhfo80qKwRgdodpoDzA%3D%0A&m=O11VWsL2B2dUuXYqEwuOUHmhshweEZYBLxHhJxNvDeM%3D%0A&s=db7df240408059cde47d5135fc6905f3ada2154e8b6a93b26a46f5b813395362
> 


More information about the Piglit mailing list