[Piglit] [PATCH 1/2] summary: fix regression and fixes summaries

Kenneth Graunke kenneth at whitecape.org
Wed Nov 20 15:16:05 PST 2013


On 11/18/2013 06:33 AM, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
> 
> Somebody broke this.

IMO, "Not Run" should never appear on the fixes or regressions page.

"Not Run" means that there is no status whatsoever in one of your files.
 It means the two results columns you gave piglit-summary-html are not
comparable.

I'm fine with "Not Run" appearing on changes.html.  It is useful to
notice when that happens.  But often times, you want to compare a
baseline run (all of piglit) and a subset run (re-run all the transform
feedback tests, for example).  Having fixes/regressions.html only show
things that actually exist allows that workflow.  Including "Not Run"
breaks it.

We seriously need to sort out what the behavior is.  You, Dylan, Tom,
and Paul should try to agree on something.  Otherwise, everybody is just
going to keep reverting everyone else's patches, claiming something is
broken.


More information about the Piglit mailing list