[Piglit] piglit-run.py regression

[Dylan Baker]

On Wednesday, November 20, 2013 04:27:03 PM Brian Paul wrote:
> On two Mint systems I'm seeing this problem:
> 
> $ ./piglit-run.py -t kil tests/all.tests results/kil
> Traceback (most recent call last):
>    File "./piglit-run.py", line 148, in <module>
>      main()
>    File "./piglit-run.py", line 118, in main
>      json_writer.write_dict_item(key, value)
>    File "/home/brian/piglit/piglit/framework/threads.py", line 36, in
> wrapper
>      return function(self, *args, **kwargs)
>    File "/home/brian/piglit/piglit/framework/core.py", line 177, in
> write_dict_item
>      self.__write(value)
>    File "/home/brian/piglit/piglit/framework/threads.py", line 36, in
> wrapper
>      return function(self, *args, **kwargs)
>    File "/home/brian/piglit/piglit/framework/core.py", line 146, in __write
>      lines = list(self.__encoder.encode(obj).split('\n'))
>    File "/usr/lib/python2.7/dist-packages/simplejson/encoder.py", line
> 239, in encode
>      chunks = list(chunks)
>    File "/usr/lib/python2.7/dist-packages/simplejson/encoder.py", line
> 540, in _iterencode
>      for chunk in _iterencode_list(o, _current_indent_level):
>    File "/usr/lib/python2.7/dist-packages/simplejson/encoder.py", line
> 422, in _iterencode_list
>      for chunk in chunks:
>    File "/usr/lib/python2.7/dist-packages/simplejson/encoder.py", line
> 561, in _iterencode
>      o = _default(o)
>    File "/home/brian/piglit/piglit/framework/core.py", line 67, in default
>      return json.JSONEncoder.default(self, o)
>    File "/usr/lib/python2.7/dist-packages/simplejson/encoder.py", line
> 213, in default
>      raise TypeError(repr(o) + " is not JSON serializable")
> TypeError: <_sre.SRE_Pattern object at 0x7fdb9aab36c0> is not JSON
> serializable
> 
> 
> Bisection says it's caused by:
> 
> commit 0618aa38d4a8a7c82994fb28a41576da9a2cc414
> Author: Dylan Baker <baker.dylan.c at gmail.com>
> Date:   Fri Nov 15 10:00:49 2013 -0800
> 
>      piglit-run.py: Record all attributes of Environment and restore them
> 
>      This causes all attributes in the Environment instance env to be dumped
> into the json and reloaded on a resume. It adds an __iter__ magic method
>      to core.Environment to allow this.
> 
> 
> -Brian

There is a bugzilla opened on this already: 
https://bugs.freedesktop.org/show_bug.cgi?id=71822

I have a patch written, and a better one I'm writing currently. Expect it very 
soon.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20131120/9a7ad592/attachment.pgp>