[Piglit] [PATCH 5/8] cmake: Increase minimum version from 2.6 to 2.8.

[Dylan Baker]

On Tuesday, October 01, 2013 05:13:52 PM Ken Phillis Jr wrote:
> The use of cmake 2.8 just happens to coincide with requiring slightly newer
> tools... see these release announcements...
> kitware - news: cmake 2.8.11 released ( May 22, 2013 )
> http://www.kitware.com/news/home/browse/464?siteid=9
> kitware - news: cmake 2.8.0 released ( November 4,2009)
> http://www.kitware.com/news/home/browse/252?siteid=9
> kitware - news:  cmake 2.6.4 released ( May 5, 2009 )
> http://www.kitware.com/news/home/browse/229?siteid=9
> 
>  On Oct 1, 2013 4:37 PM, "Dylan Baker" <baker.dylan.c at gmail.com> wrote:
> > On Monday, September 30, 2013 10:11:05 PM Kenney Phillis wrote:
> > > Increase the Minimum version of CMake that is required from
> > > version 2.6 to version 2.8. This is because the minimum requirement
> > > to compile waffle is version 2.8
> > > ---
> > > 
> > >  CMakeLists.txt |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/CMakeLists.txt b/CMakeLists.txt
> > > index f064b35..0da074a 100644
> > > --- a/CMakeLists.txt
> > > +++ b/CMakeLists.txt
> > > @@ -1,4 +1,4 @@
> > > -cmake_minimum_required(VERSION 2.6)
> > > +cmake_minimum_required(VERSION 2.8)
> > > 
> > >  list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake/Modules")
> > 
> > I don't think we need this. Waffle is a seperate project and a not a
> > dependency
> > (if running on non-linux platforms), besides that dependency ordering is
> > waffle
> > then piglit, so either you have 2.8, or you don't need it.
> > 
> > Just my 2cents.

OK, didn't see anything in there that explained why we need 2.8.x when 2.6.x 
is working.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20131001/d2be9a5b/attachment.pgp>