[Piglit] [PATCH 5/8] GL3.2 GL_ARB_sync: Test that GetSynciv sets correct error codes.

Nicholas Mack nichmack at gmail.com
Mon Oct 7 17:46:47 CEST 2013


v2: Fix comments, initialize variables

v3: Minor fixes and add to all.tests
---
 tests/all.tests                        |  1 +
 tests/spec/arb_sync/CMakeLists.gl.txt  |  1 +
 tests/spec/arb_sync/GetSynciv-errors.c | 91 ++++++++++++++++++++++++++++++++++
 3 files changed, 93 insertions(+)
 create mode 100644 tests/spec/arb_sync/GetSynciv-errors.c

diff --git a/tests/all.tests b/tests/all.tests
index d6fb319..ee2c8df 100644
--- a/tests/all.tests
+++ b/tests/all.tests
@@ -1103,6 +1103,7 @@ arb_sync['ClientWaitSync-errors'] = concurrent_test('arb_sync-ClientWaitSync-err
 arb_sync['ClientWaitSync-returns'] = concurrent_test('arb_sync-ClientWaitSync-returns')
 arb_sync['DeleteSync'] = concurrent_test('arb_sync-DeleteSync')
 arb_sync['FenceSync-errors'] = concurrent_test('arb_sync-FenceSync-errors')
+arb_sync['GetSynciv-errors'] = concurrent_test('arb_sync-GetSynciv-errors')
 arb_sync['repeat-wait'] = concurrent_test('arb_sync-repeat-wait')
 arb_sync['timeout-zero'] = concurrent_test('arb_sync-timeout-zero')
 add_plain_test(arb_sync, 'sync_api')
diff --git a/tests/spec/arb_sync/CMakeLists.gl.txt b/tests/spec/arb_sync/CMakeLists.gl.txt
index bbeab54..b6840e1 100644
--- a/tests/spec/arb_sync/CMakeLists.gl.txt
+++ b/tests/spec/arb_sync/CMakeLists.gl.txt
@@ -14,5 +14,6 @@ piglit_add_executable (arb_sync-client-wait-errors ClientWaitSync-errors.c)
 piglit_add_executable (arb_sync-client-wait-returns ClientWaitSync-returns.c)
 piglit_add_executable (arb_sync-delete-sync DeleteSync.c)
 piglit_add_executable (arb_sync-fence-errors FenceSync-errors.c)
+piglit_add_executable (arb_sync-get-sync-errors GetSynciv-errors.c)
 piglit_add_executable (arb_sync-repeat-wait repeat-wait.c)
 piglit_add_executable (arb_sync-timeout-zero timeout-zero.c)
diff --git a/tests/spec/arb_sync/GetSynciv-errors.c b/tests/spec/arb_sync/GetSynciv-errors.c
new file mode 100644
index 0000000..472c05e
--- /dev/null
+++ b/tests/spec/arb_sync/GetSynciv-errors.c
@@ -0,0 +1,91 @@
+/**
+ * Copyright © 2013 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/**
+ * \file
+ * Test GetSynciv() sets correct error codes
+ *
+ * Section 6.1.7(Sync Object Queries) of OpenGL 3.2 Core says:
+ *  (For GetSynciv) "If sync is not the name of a sync object, an INVALID_VALUE
+ *  error is generated. If pname is not one of the values described above, an
+ *  INVALID_ENUM error is generated."
+ *
+ */
+
+#include "piglit-util-gl-common.h"
+
+PIGLIT_GL_TEST_CONFIG_BEGIN
+
+	config.supports_gl_compat_version = 10;
+	config.supports_gl_core_version = 31;
+
+PIGLIT_GL_TEST_CONFIG_END
+
+enum piglit_result
+piglit_display(void)
+{
+	/* UNREACHED */
+	return PIGLIT_FAIL;
+}
+
+void
+piglit_init(int argc, char **argv)
+{
+	bool pass = true;
+	GLsync valid_fence;
+	GLsync invalid_fence = (GLsync) 0x1373;
+
+	GLsizei len;
+	GLint val;
+
+	if (piglit_get_gl_version() < 32) {
+		piglit_require_extension("GL_ARB_sync");
+	}
+
+	valid_fence = glFenceSync(GL_SYNC_GPU_COMMANDS_COMPLETE, 0);
+
+	/* test that invalid sync results in INVALID_VALUE */
+	glGetSynciv(invalid_fence, GL_SYNC_STATUS, 1, &len, &val);
+	pass = piglit_check_gl_error(GL_INVALID_VALUE) && pass;
+
+	/* test valid pname values result in NO_ERROR */
+	glGetSynciv(valid_fence, GL_OBJECT_TYPE, 1, &len, &val);
+	pass = piglit_check_gl_error(GL_NO_ERROR) && pass;
+
+	glGetSynciv(valid_fence, GL_SYNC_STATUS, 1, &len, &val);
+	pass = piglit_check_gl_error(GL_NO_ERROR) && pass;
+
+	glGetSynciv(valid_fence, GL_SYNC_CONDITION, 1, &len, &val);
+	pass = piglit_check_gl_error(GL_NO_ERROR) && pass;
+
+	glGetSynciv(valid_fence, GL_SYNC_FLAGS, 1, &len, &val);
+	pass = piglit_check_gl_error(GL_NO_ERROR) && pass;
+
+	/* test that invalid pname results in INVALID_ENUM */
+	glGetSynciv(valid_fence, GL_INVALID_VALUE, 1, &len, &val);
+	pass = piglit_check_gl_error(GL_INVALID_ENUM) && pass;
+
+	glDeleteSync(valid_fence);
+
+	piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+}
-- 
1.8.3.1



More information about the Piglit mailing list