[Piglit] [PATCH 7/8] GL3.2 GL_ARB_sync: Test that a sync object is initialized with the correct properties

Nicholas Mack nichmack at gmail.com
Mon Oct 7 17:46:49 CEST 2013


v2: Fix comments, add extra checks for length variable being modified

v3: Start some rendering to insure initialized values and add to all.tests
---
 tests/all.tests                       |   1 +
 tests/spec/arb_sync/CMakeLists.gl.txt |   1 +
 tests/spec/arb_sync/sync-initialize.c | 134 ++++++++++++++++++++++++++++++++++
 3 files changed, 136 insertions(+)
 create mode 100644 tests/spec/arb_sync/sync-initialize.c

diff --git a/tests/all.tests b/tests/all.tests
index a842790..e56ae38 100644
--- a/tests/all.tests
+++ b/tests/all.tests
@@ -1106,6 +1106,7 @@ arb_sync['FenceSync-errors'] = concurrent_test('arb_sync-FenceSync-errors')
 arb_sync['GetSynciv-errors'] = concurrent_test('arb_sync-GetSynciv-errors')
 arb_sync['IsSync'] = concurrent_test('arb_sync-IsSync')
 arb_sync['repeat-wait'] = concurrent_test('arb_sync-repeat-wait')
+arb_sync['sync-initialize'] = concurrent_test('arb_sync-sync-initialize')
 arb_sync['timeout-zero'] = concurrent_test('arb_sync-timeout-zero')
 add_plain_test(arb_sync, 'sync_api')
 
diff --git a/tests/spec/arb_sync/CMakeLists.gl.txt b/tests/spec/arb_sync/CMakeLists.gl.txt
index 038e0e1..9855d69 100644
--- a/tests/spec/arb_sync/CMakeLists.gl.txt
+++ b/tests/spec/arb_sync/CMakeLists.gl.txt
@@ -17,4 +17,5 @@ piglit_add_executable (arb_sync-fence-errors FenceSync-errors.c)
 piglit_add_executable (arb_sync-get-sync-errors GetSynciv-errors.c)
 piglit_add_executable (arb_sync-is-sync IsSync.c)
 piglit_add_executable (arb_sync-repeat-wait repeat-wait.c)
+piglit_add_executable (arb_sync-sync-initialize sync-initialize.c)
 piglit_add_executable (arb_sync-timeout-zero timeout-zero.c)
diff --git a/tests/spec/arb_sync/sync-initialize.c b/tests/spec/arb_sync/sync-initialize.c
new file mode 100644
index 0000000..706db02
--- /dev/null
+++ b/tests/spec/arb_sync/sync-initialize.c
@@ -0,0 +1,134 @@
+/**
+ * Copyright © 2013 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/**
+ * \file
+ * Test that a sync is initialized correctly with FenceSync
+ *
+ * Section 5.2(Sync Objects and Fences) of OpenGL 3.2 Core says:
+ * 	"Table 5.1: Initial properties of a sync object created with FenceSync."
+ *
+ * 	 Property Name	Property Value
+ * 	--------------------------------------
+ * 	 OBJECT_TYPE		SYNC_FENCE
+ * 	 SYNC_CONDITION	<condition>
+ * 	 SYNC_STATUS		UNSIGNALED
+ * 	 SYNC_FLAGS		<flags>
+ *
+ */
+
+#include "piglit-util-gl-common.h"
+
+PIGLIT_GL_TEST_CONFIG_BEGIN
+
+config.supports_gl_compat_version = 10;
+config.supports_gl_core_version = 31;
+
+PIGLIT_GL_TEST_CONFIG_END
+
+enum piglit_result
+piglit_display(void)
+{
+	/* UNREACHED */
+	return PIGLIT_FAIL;
+}
+
+void
+piglit_init(int argc, char **argv)
+{
+	bool pass = true;
+	GLsizei length = -5;
+	GLint value;
+	GLsync sync;
+
+	if (piglit_get_gl_version() < 32) {
+		piglit_require_extension("GL_ARB_sync");
+	}
+
+	/* Start some rendering that will not end before this test finishes
+	 * in order to make sure the fence sync is still set to initial values
+	 */
+	piglit_draw_rect(-1, -1, 2, 2);
+
+	/* Create a new fence sync */
+	sync = glFenceSync(GL_SYNC_GPU_COMMANDS_COMPLETE, 0);
+
+	/* Test initialized as fence type */
+	glGetSynciv(sync, GL_OBJECT_TYPE, 1, &length, &value);
+	if(length != 1) {
+		printf("length should be 1 but incorrectly returned: %d\n",
+			length);
+		pass = false;
+	}
+	if(value != GL_SYNC_FENCE) {
+		printf("Expected GL_SYNC_FENCE but returned: %s\n",
+			piglit_get_gl_enum_name(value));
+		pass = false;
+	}
+
+	/* Test initialized to given condition */
+	length = -5;
+	glGetSynciv(sync, GL_SYNC_CONDITION, 1, &length, &value);
+	if(length != 1) {
+		printf("length should be 1 but incorrectly returned: %d\n",
+			length);
+		pass = false;
+	}
+	if(value != GL_SYNC_GPU_COMMANDS_COMPLETE) {
+		printf("Expected GL_SYNC_GPU_COMMANDS_COMPLETE but returned: %s\n",
+			piglit_get_gl_enum_name(value));
+		pass = false;
+	}
+
+	/* Test initialized to unsignaled */
+	length = -5;
+	glGetSynciv(sync, GL_SYNC_STATUS, 1, &length, &value);
+	if(length != 1) {
+		printf("length should be 1 but incorrectly returned: %d\n",
+			length);
+		pass = false;
+	}
+	if(value != GL_UNSIGNALED) {
+		printf("Expected GL_UNSIGNALED but returned: %s\n",
+			piglit_get_gl_enum_name(value));
+		pass = false;
+	}
+
+	/* Test initialized with given flag */
+	length = -5;
+	glGetSynciv(sync, GL_SYNC_FLAGS, 1, &length, &value);
+	if(length != 1) {
+		printf("length should be 1 but incorrectly returned: %d\n",
+			length);
+		pass = false;
+	}
+	if(value != 0) {
+		printf("Expected GL_SYNC_FLAGS == 0 but returned: %d\n",
+			value);
+		pass = false;
+	}
+
+	glDeleteSync(sync);
+
+	piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+}
-- 
1.8.3.1



More information about the Piglit mailing list