[Piglit] [PATCH] GL 1.50: Test that UNIFORM_BLOCK_REFERENCED_BY_GEOMETRY_SHADER is accepted by GetActiveUniformBlockiv()

[Eric Anholt]

Nicholas Mack <nichmack at gmail.com> writes:

> v2: Incorporate this test into referenced-by-shader.c

> @@ -40,10 +41,6 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>  
>  	config.supports_gl_compat_version = 10;
>  
> -	config.window_width = 10;
> -	config.window_height = 10;
> -	config.window_visual = PIGLIT_GL_VISUAL_RGBA | PIGLIT_GL_VISUAL_DOUBLE;
> -

It looks like this won't ever get run on a 3.2 context on Mesa because
you need at least config.supports_gl_core_version = 31.

> +	bool use_gs = piglit_get_gl_version() >= 32;
> +	const char *header;
> +	char *temp_source;
> +	int num_uniforms_used = 0;
> +
> +	if(use_gs) {

There should always be a space between 'if' and '('

> -	for (i = 0; i < 3; i++) {
> -		GLint ref_vs, ref_fs;
> +	if(use_gs) {
> +		num_uniforms_used = 7;
> +		printf("            v g f\n");
> +	}
> +	else {

Usually we cuddle the braces like "} else {"

With the one functional fix and the little style nits fixed, this would
be:

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20131007/2535f45b/attachment.pgp>