[Piglit] [PATCH] geometry-end-primitive-optional-with-points-out: Require GLSL 1.50.

[Paul Berry]

On 8 October 2013 15:22, Vinson Lee <vlee at freedesktop.org> wrote:

> On Tue, Oct 8, 2013 at 2:05 PM, Paul Berry <stereotype441 at gmail.com>
> wrote:
> > On 8 October 2013 13:55, Vinson Lee <vlee at freedesktop.org> wrote:
> >>
> >> On Tue, Oct 8, 2013 at 12:47 PM, Paul Berry <stereotype441 at gmail.com>
> >> wrote:
> >> > On 8 October 2013 11:56, Vinson Lee <vlee at freedesktop.org> wrote:
> >> >>
> >> >> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> >> >> ---
> >> >>  .../geometry/geometry-end-primitive-optional-with-points-out.c
> >> >> |
> >> >> 2 ++
> >> >>  1 file changed, 2 insertions(+)
> >> >>
> >> >> diff --git
> >> >>
> >> >>
> a/tests/spec/glsl-1.50/execution/geometry/geometry-end-primitive-optional-with-points-out.c
> >> >>
> >> >>
> b/tests/spec/glsl-1.50/execution/geometry/geometry-end-primitive-optional-with-points-out.c
> >> >> index d6c4b44..13fb7eb 100644
> >> >> ---
> >> >>
> >> >>
> a/tests/spec/glsl-1.50/execution/geometry/geometry-end-primitive-optional-with-points-out.c
> >> >> +++
> >> >>
> >> >>
> b/tests/spec/glsl-1.50/execution/geometry/geometry-end-primitive-optional-with-points-out.c
> >> >> @@ -93,6 +93,8 @@ piglit_init(int argc, char **argv)
> >> >>         GLuint vs = 0, gs = 0, fs = 0;
> >> >>         GLuint vertIndex;
> >> >>
> >> >> +       piglit_require_GLSL_version(150);
> >> >> +
> >> >>         prog = glCreateProgram();
> >> >>         vs = piglit_compile_shader_text(GL_VERTEX_SHADER, vstext);
> >> >>         gs = piglit_compile_shader_text(GL_GEOMETRY_SHADER, gstext);
> >> >> --
> >> >> 1.8.1.2
> >> >
> >> >
> >> > The test already specifies
> >> >
> >> >     config.supports_gl_compat_version = 32;
> >> >     config.supports_gl_core_version = 32;
> >> >
> >> > and GL 3.2 requires GLSL 1.50, so it seems to me that this shouldn't
> be
> >> > necessary.
> >>
> >>
> >> I'm seeing this test fail on swrast instead of reporting a skip.
> >
> >
> > That's strange.  When I run this test with LIBGL_ALWAYS_SOFTWARE=1 I get:
> >
> > piglit: info: Failed to create GL 3.2 core context
> > piglit: info: Falling back to GL 3.2 compatibility context
> > piglit: info: Requested a GL 3.2 compatibility context, but actual
> context
> > version is 2.1
> > piglit: info: Failed to create GL 3.2 compatibility context
> > piglit: info: Failed to create any GL context
> > PIGLIT: {'result': 'skip' }
>
>
> I'm using piglit without waffle.
>

Ok.  It looks like there's a bug in piglit's glut framework--it's not
paying attention to the value of config.supports_gl_compat_version.

I'll submit a patch shortly to fix this.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20131008/1766e801/attachment-0001.html>