[Piglit] [PATCH] shaders: add test for bool casting of large integers.

Dave Airlie airlied at gmail.com
Wed Oct 9 05:41:54 CEST 2013


On Wed, Oct 9, 2013 at 2:30 AM, Ian Romanick <idr at freedesktop.org> wrote:
> On 10/07/2013 04:22 PM, Dave Airlie wrote:
>> From: Dave Airlie <airlied at redhat.com>
>>
>> I noticed the TGSI convertor just does INEG then AND 0x3f800000, which works
>> for small values, but fails for larger ints.
>>
>> This seems to fail on nvidia (4.3.0 NVIDIA 325.15) and on ironlake with mesa
>> 9.2.
>
> If you repost the patch, could you CC Wen Su <wsu at nvidia.com>?
>
> Also, is there a bugzilla for this issue?

No there is only this lonely piglit test,
>> +[test]
>> +uniform int arg0 0x0ff00001
>
> This value seems magic.  Why did you pick that?  Are there other large
> values that should also be tested.

I don't think so my assumption was that everyone is doing -val & 0x3f800000
(at least thats what gallium does) so I wanted a value with some bits
sets in the same range and some other
bits set outside it, but really its as valid as any other magic value.

Dave.


More information about the Piglit mailing list