[Piglit] [PATCH] ARB_texture_view: Add test suite

Jon Ashburn jon at lunarg.com
Wed Oct 16 21:58:13 CEST 2013


Matt:

Thanks for clarification, I understand now why the test is in 
arb_texture_view directory and the purpose it serves.  I still think 
testing TEXTURE_IMMUTABLE_LEVELS and TEXTURE_VIEW_NUM_LEVELS after a 
glTextureView() is good additional test case to have over and above the 
testing of these after glTexStorage(), as the texture-immutable_levels.c 
does.

What do you think?

Jon
On 10/16/2013 01:42 PM, Matt Turner wrote:
> On Wed, Oct 16, 2013 at 12:30 PM, Jon Ashburn <jon at lunarg.com> wrote:
>> I am not sure why the texture-immutable-levels.c file is in the
>> arb_texture_view  directory since
>> it doesn't actually call glTextureView(). Should it be in the
>> arb_texture_storage directory instead?
> The background is that ES 3 adds TEXTURE_IMMUTABLE_LEVELS which I
> needed to test (test/spec/gles-3.0/texture-immutable-levels.c) and
> basically the same test is suitable for ARB_texture_view, so I added
> that too.
>
> ARB_texture_storage does not have TEXTURE_IMMUTABLE_LEVELS or
> TEXTURE_VIEW_NUM_LEVELS, which is what
> tests/spec/arb_texture_view/texture-immutable-levels.c tests. Those
> tokens are added to desktop GL in ARB_texture_view.



More information about the Piglit mailing list