[Piglit] [PATCH 8/9] summary.py: rename generate* methods
Chris Forbes
chrisf at ijw.co.nz
Thu Oct 17 06:17:03 CEST 2013
+ def generate_HTML(self, destination, exclude):
Would probably go with 'generate_html'
On Tue, Oct 15, 2013 at 11:13 PM, Dylan Baker <baker.dylan.c at gmail.com> wrote:
> Fix style issues with camel case method names.
>
> Signed-off-by: Dylan Baker <baker.dylan.c at gmail.com>
> ---
> framework/summary.py | 4 ++--
> piglit-summary-html.py | 2 +-
> piglit-summary.py | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/framework/summary.py b/framework/summary.py
> index 67184b2..3ab71f3 100644
> --- a/framework/summary.py
> +++ b/framework/summary.py
> @@ -396,7 +396,7 @@ class Summary:
> for test in self.results[-1].tests.values():
> self.totals[str(test['result'])] += 1
>
> - def generateHTML(self, destination, exclude):
> + def generate_HTML(self, destination, exclude):
> """
> Produce HTML summaries.
>
> @@ -502,7 +502,7 @@ class Summary:
>
> file.close()
>
> - def generateText(self, diff, summary):
> + def generate_text(self, diff, summary):
> """ Write summary information to the console """
> self.__find_totals()
>
> diff --git a/piglit-summary-html.py b/piglit-summary-html.py
> index b9a2996..8965473 100755
> --- a/piglit-summary-html.py
> +++ b/piglit-summary-html.py
> @@ -82,7 +82,7 @@ def main():
>
> # Create the HTML output
> output = summary.Summary(args.resultsFiles)
> - output.generateHTML(args.summaryDir, args.exclude_details)
> + output.generate_HTML(args.summaryDir, args.exclude_details)
>
>
> if __name__ == "__main__":
> diff --git a/piglit-summary.py b/piglit-summary.py
> index ebc01b8..fa934b4 100755
> --- a/piglit-summary.py
> +++ b/piglit-summary.py
> @@ -73,7 +73,7 @@ def main():
>
> # Generate the output
> output = summary.Summary(args.results)
> - output.generateText(args.diff, args.summary)
> + output.generate_text(args.diff, args.summary)
>
>
> if __name__ == "__main__":
> --
> 1.8.1.5
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
More information about the Piglit
mailing list