[Piglit] [PATCH 2/3] arb_texture_view: Test valid and invalid formats

[Brian Paul]

On 10/17/2013 12:42 PM, Ian Romanick wrote:
> On 10/17/2013 07:29 AM, Brian Paul wrote:
>> On 10/16/2013 05:37 PM, Jon Ashburn wrote:

>>> +    /* skip compressed internal formats for now including extensions */
>>> +    assert(format_class == GL_VIEW_CLASS_128_BITS ||
>>> +           format_class == GL_VIEW_CLASS_96_BITS ||
>>> +           format_class == GL_VIEW_CLASS_64_BITS ||
>>> +           format_class == GL_VIEW_CLASS_48_BITS ||
>>> +           format_class == GL_VIEW_CLASS_32_BITS ||
>>> +           format_class == GL_VIEW_CLASS_24_BITS ||
>>> +           format_class == GL_VIEW_CLASS_16_BITS ||
>>> +           format_class == GL_VIEW_CLASS_8_BITS);
>>
>> I think you could remove this assertion and just add a default switch
>> case below to catch invalid values.
>
> I think he copied this from /your/ texture-storage test. :)

Not AFAICT. :)


-Brian