[Piglit] [PATCH 1/5] util: Move command-line parsing out of piglit_gl_test_config_init

Chad Versace chad.versace at linux.intel.com
Tue Oct 22 01:51:28 CEST 2013


On 10/15/2013 05:32 PM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> Create a new function, piglit_gl_process_args, that does the
> command-line parsing.  This happens after the test code between
> PIGLIT_GL_TEST_CONFIG_BEGIN and PIGLIT_GL_TEST_CONFIG_END.  By having an
> explicit function that does this, tests can call it inside the BEGIN/END
> block.  This may be useful for tests that expect certain arguments to be
> in specific positions.
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> Cc: Chad Versace <chad.versace at linux.intel.com>
> ---
>   tests/texturing/shaders/texelFetch.c  | 10 ++++++----
>   tests/texturing/shaders/textureSize.c | 10 ++++++----
>   tests/util/piglit-framework-gl.c      | 24 ++++++++++++++----------
>   tests/util/piglit-framework-gl.h      | 10 +++++++---
>   4 files changed, 33 insertions(+), 21 deletions(-)
>

As Paul requested, explain in a comment that it's safe to call
piglit_gl_process_args() twice b/c it's idempotent, and patch 1
is

Reviewed-by: Chad Versace <chad.versace at linux.intel.com>



More information about the Piglit mailing list