[Piglit] [PATCH 0/8] Various Fixes on Cmake and opengl.

[Chad Versace]

On 09/30/2013 08:11 PM, Kenney Phillis wrote:
> Cmake fix 1: Fix problems involving out of tree builds
> cmake fix 2: fix some missing files from installer.
>
> config.h.in: applied a slightly more correct location
> for the HAVE_STRNDUP define.
>
> tests/util fixes: Updated changelog from previous commit.
>
> Kenney Phillis (8):
>    cmake: fix out of tree Installation and package generation.
>    cmake: add *.geom to the list of installed files.
>    cmake: add *.cl to the list of installed generated tests.
>    cmake: ignore the "CMakeFiles" folder in generated_tests installer
>    cmake: Increase minimum version from 2.6 to 2.8.
>    config.h.in: add define for HAVE_STRNDUP
>    piglit-util-gl-common: Add Function to clear extensions list.
>    util/waffle: reinitialize extensions
>
>   CMakeLists.txt                                     |    9 +++++----
>   tests/util/config.h.in                             |    1 +
>   .../piglit-framework-gl/piglit_wfl_framework.c     |    2 ++
>   tests/util/piglit-util-gl-common.c                 |    8 ++++++++
>   tests/util/piglit-util-gl-common.h                 |    5 +++++
>   5 files changed, 21 insertions(+), 4 deletions(-)

Thanks a lot for the installation fixes. I also install Piglit to
test machines, so the improvements help me.

Until now, I have used a custom installation script rather than relying
on CMake, due to the bugs you found and solved. Now I can use the real
'install' rule and abandon my hacky script.

Patches 1-4 6-8 are
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>
I will perform a regression run and then commit if I find
no problems.

See patch 5 for my comments there.